[review] gdb: recognize new DWARF attributes: defaulted, deleted, calling conv.

["Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135
......................................................................


Patch Set 1:

(2 comments)

Thank you for the patch.  This looks essentially good to me.  I had a couple of nits,
related to structure packing and size.

I assume this is used elsewhere in your series.  Now that we're on gerrit and can't
do cover letters, I think it would be helpful if supporting patches like this could
mention facts like that... something for us all to consider as we write commit
messages.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h 
File gdb/gdbtypes.h:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h@929 
PS1, Line 929:   unsigned int defaulted;
Should this be a bit-field or a narrower integer type?
I see `DW_DEFAULTED` only has 3 values at present.

I guess we'd have to deal with the situation where the DWARF
gives some random value here?

Offhand I'm not sure whether space is a big consideration here
or not, but my default with symbols and types is to assume that it is.


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h@1101 
PS1, Line 1101:     unsigned calling_convention : 8;
This might pack better up near the `is_dynamic` field.