This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Save plain text in the source cache
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Tom Tromey <tromey at adacore dot com>
- Cc: GDB <gdb-patches at sourceware dot org>
- Date: Tue, 22 Oct 2019 16:39:49 -0700
- Subject: Re: [PATCH 2/4] Save plain text in the source cache
- References: <20190726133422.5896-1-tromey@adacore.com> <20190726133422.5896-3-tromey@adacore.com>
On Fri, Jul 26, 2019 at 6:34 AM Tom Tromey <tromey@adacore.com> wrote:
>
> Currently the source cache will only store highlighted text. However,
> there's no reason it could not also store plain text, when styling is
> turned off.
>
> This patch makes this change. This also simplifies the source cache
> code somewhat.
>
> gdb/ChangeLog
> 2019-07-26 Tom Tromey <tromey@adacore.com>
>
> * source-cache.c (source_cache::get_plain_source_lines):
> Remove "first_line" and "last_line" parameters.
> (source_cache::get_source_lines): Cache plain text.
> * source-cache.h (class source_cache)
> <get_plain_source_lines>: Update.
This caused:
https://sourceware.org/bugzilla/show_bug.cgi?id=25126
--
H.J.