This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v2] Don't make an extra copy + allocation of the demangled name
- From: "Christian Biesinger (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>, Luis Machado <luis dot machado at linaro dot org>
- Date: Tue, 22 Oct 2019 15:04:00 -0400
- Subject: [review v2] Don't make an extra copy + allocation of the demangled name
- Auto-submitted: auto-generated
- References: <gerrit.1571352433000.Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0@gnutoolchain-gerrit.osci.io>
- Reply-to: cbiesinger at google dot com, simon dot marchi at polymtl dot ca, luis dot machado at linaro dot org, cbiesinger at google dot com, gdb-patches at sourceware dot org
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132
......................................................................
Uploaded patch set 2.
(3 comments)
rebased
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c
File gdb/symtab.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@718
PS1, Line 718: char* demangled;
> Usual style is "char *demangled;" i think. Although there is one offender in symtab.c already.
I rebased & followed Simon's suggestion, so this comment is moot now.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@718
PS1, Line 718: char* demangled;
> Would it make sense to rebase that patch over your other series (especially https://gnutoolchain-ger […]
Done
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@887
PS1, Line 887:
> Something odd here? Whitespace?
Yeah, there's whitespace on this line. This was already pre-existing but I removed it now.