This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] [gdb/breakpoints] Fix fullname.exp when run from symlink dir
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tom de Vries <tdevries at suse dot de>, gdb-patches at sourceware dot org
- Date: Tue, 22 Oct 2019 14:10:30 -0400
- Subject: [review] [gdb/breakpoints] Fix fullname.exp when run from symlink dir
- Auto-submitted: auto-generated
- References: <gerrit.1571152703000.I1ace62a234458781e958980f3b425edf1490df27@gnutoolchain-gerrit.osci.io>
- Reply-to: tromey at sourceware dot org, tdevries at suse dot de, gdb-patches at sourceware dot org
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/82
......................................................................
Patch Set 1: Code-Review+2
Thank you for the patch. I'm sorry it took so long to review.
This is a tricky area and I procrastinated a while.
I think this patch is OK. In the long run, I think I'd prefer that
we move the fullname out of the symtab and instead have a dedicated
cache for it (perhaps in source_cache). Then we could compute both
the user-facing name and the canonical ("real") name, and efficiently
choose the one needed at any given point.
However, that's reasonably involved and, I think, not required for this to land.