This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v5] Store the mangled name as a string_view
- From: "Christian Biesinger (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at sourceware dot org>, Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Tue, 22 Oct 2019 12:17:29 -0400
- Subject: [review v5] Store the mangled name as a string_view
- Auto-submitted: auto-generated
- References: <gerrit.1571050562000.I24711ae2bcaa9e79ca89a6f8fda385d400419175@gnutoolchain-gerrit.osci.io>
- Reply-to: cbiesinger at google dot com, simon dot marchi at polymtl dot ca, tromey at sourceware dot org, cbiesinger at google dot com, gdb-patches at sourceware dot org
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37
......................................................................
Patch Set 5:
(1 comment)
Thanks for the reviews! Will push once I update the rest of this patch series per your comments.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/5/gdb/symtab.c
File gdb/symtab.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/5/gdb/symtab.c@903
PS5, Line 903: new (*slot) demangled_name_entry
> FWIW I don't think there's a deep reason these objects have to […]
OK, I'll keep that in mind.