This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v3] Store the mangled name as a string_view
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Date: Mon, 21 Oct 2019 18:39:51 -0400
- Subject: [review v3] Store the mangled name as a string_view
- Auto-submitted: auto-generated
- References: <gerrit.1571050562000.I24711ae2bcaa9e79ca89a6f8fda385d400419175@gnutoolchain-gerrit.osci.io>
- Reply-to: simon dot marchi at polymtl dot ca, cbiesinger at google dot com, gdb-patches at sourceware dot org
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37
......................................................................
Patch Set 3:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/3/gdb/symtab.c
File gdb/symtab.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/3/gdb/symtab.c@891
PS3, Line 891: + demangled_len + 1));
Pedantically, since demangled_name_entry is now a non-POD, we should run the constructor here and the destructor when we release them. Running the constructor here would not be too complicated, but running the destructor might be a bit more (and maybe it's not really necessary), I guess we'd need a "delete" function on the htab.