This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] infcall: move assertions in 'call_function_by_hand_dummy' to an earli...
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tankut Baris Aktemur <tankut dot baris dot aktemur at intel dot com>, gdb-patches at sourceware dot org
- Cc: Luis Machado <luis dot machado at linaro dot org>, Tom de Vries <tdevries at suse dot de>
- Date: Mon, 21 Oct 2019 15:00:30 -0400
- Subject: [review] infcall: move assertions in 'call_function_by_hand_dummy' to an earli...
- Auto-submitted: auto-generated
- References: <gerrit.1571406803000.I411ac083ac6a9ee6eb93c4b82393a81a4fc927be@gnutoolchain-gerrit.osci.io>
- Reply-to: simon dot marchi at polymtl dot ca, tankut dot baris dot aktemur at intel dot com, tdevries at suse dot de, luis dot machado at linaro dot org, gdb-patches at sourceware dot org
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+1
>
> I'd make it clear, in the cover letter/commit message, the reason for refactoring. As for the explanation, it sounds good to me.
>
> I agree we should check all the easy things before doing any further processing towards a function call. This looks like a small optimization of sorts.
Agreed, please put this in the commit message.