Re: Gerrit emails

[Sergio Durigan Junior <sergiodj at redhat dot com>]

On Thursday, October 17 2019, Simon Marchi wrote:

> On 2019-10-17 3:12 a.m., Eli Zaretskii wrote:
>> Gerrit-generated emails I get from the list have the addressee headers
>> set as follows:
>> 
>>   From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
>>   To: Christian Biesinger <cbiesinger@google.com>,	gdb-patches@sourceware.org
>>   Cc: Tom de Vries <tdevries@suse.de>,	Simon Marchi <simon.marchi@polymtl.ca>
>>   Reply-To: cbiesinger@google.com, simon.marchi@polymtl.ca, tdevries@suse.de, cbiesinger@google.com, gdb-patches@sourceware.org
>> 
>> (It could be that some of these are generated by the list server, not
>> by Gerrit itself.)
>> 
>> This causes Emacs's Rmail to produce duplicate addresses in the reply
>> email:
>> 
>>   To: cbiesinger@google.com, simon.marchi@polymtl.ca, tdevries@suse.de, cbiesinger@google.com, gdb-patches@sourceware.org
>>   Cc: cbiesinger@google.com,	gdb-patches@sourceware.org, tdevries@suse.de,	simon.marchi@polymtl.ca
>> 
>> And that forces me to manually edit the email headers of the response
>> before sending, which is a nuisance.
>> 
>> Can this be fixed not to produce duplicate addresses, please?
>> 
>> TIA
>
> Hi Eli,
>
> Ok, so the addresses are duplicated between the "To:" and the "Reply-to:" fields.

I've been thinking about these messages.  I don't think it is benefitial
to include the email addresses of all of the parties involved in the
review process in the Reply-To field.  Ideally, the Reply-To would only
contain gerrit's email address, so that the person can reply to gerrit,
and gerrit will manage the notifications accordingly.  Our instance
still doesn't process emails, but that's about to change (see below).

> I am not sure what a client is expected to do in that case.  There seems to be some
> divergence between clients, for example Thunderbird doesn't duplicate the addresses
> when I hit "Reply all".  Perhaps Rmail can be modified to not put an address in CC
> if it sees it's already in the To field?
>
> I did not find any setting in Gerrit to omit the "Reply-to" field of the sent messages,
> so I fear it won't be possible to change it in the immediate.  I can try to look
> at modifying Gerrit from source, but that will take a bit of time.
>
> Another annoyance on my side is that when I hit "Reply all", it includes the address
> of the sender, gerrit@gnutoolchain-gerrit.osci.io.  However, that domain
> (gnutoolchain-gerrit.osci.io) is not configured to forward mails, so I then receive
> delivery failure notices.  I think we need to work on that, ideally making Gerrit receive
> and process the emails.

I talked to OSCI and they will provide us a mailbox that we can use for
gerrit.  I'm just waiting for them to set it up and give me the
password.  Once we have it, I will modify our configuration file to use
this mailbox, and gerrit says that if receivemail is enabled, the
Reply-To address is set to the same value as the "From" field.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/