This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 10/23] Some get_last_target_status tweaks
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 17 Oct 2019 02:14:15 +0100
- Subject: Re: [PATCH 10/23] Some get_last_target_status tweaks
- References: <20190906232807.6191-1-palves@redhat.com> <20190906232807.6191-11-palves@redhat.com> <87v9u18foq.fsf@tromey.com>
On 9/9/19 7:53 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> - Declare nullify_last_target_wait_ptid in a header, and remove the
> Pedro> local extern declaration from linux-fork.c.
>
> Pedro> diff --git a/gdb/infrun.h b/gdb/infrun.h
> Pedro> index 30374ee51c..042edbbb66 100644
> Pedro> --- a/gdb/infrun.h
> Pedro> +++ b/gdb/infrun.h
> Pedro> @@ -107,6 +107,8 @@ extern void get_last_target_status (ptid_t *ptid,
> Pedro> extern void set_last_target_status (ptid_t ptid,
> Pedro> struct target_waitstatus status);
>
> Pedro> +extern void nullify_last_target_wait_ptid ();
>
> This could use an intro comment.
>
I've added:
+/* Clear the cached copy of the last ptid/waitstatus returned by
+ target_wait(). */
Also moved the intro comments of get_last_target_status / set_last_target_status
to the header file.
Thanks,
Pedro Alves