This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] gdb/testsuite: Introduce compiler_supports_ctf_debug guard function
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Wed, 16 Oct 2019 14:02:21 -0400
- Subject: [review] gdb/testsuite: Introduce compiler_supports_ctf_debug guard function
- Auto-submitted: auto-generated
- References: <gerrit.1571177353000.I505c11169a9bc9871a31fc0c61e119f92f32cc63@gnutoolchain-gerrit.osci.io>
- Reply-to: tromey at sourceware dot org, andrew dot burgess at embecosm dot com, gdb-patches at sourceware dot org
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121
......................................................................
Patch Set 1:
(1 comment)
Thanks for the patch.
I tend to suspect this should wait for the other patch (mentioned below).
What do you think?
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121/1/gdb/testsuite/gdb.base/ctf-whatis.exp
File gdb/testsuite/gdb.base/ctf-whatis.exp:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121/1/gdb/testsuite/gdb.base/ctf-whatis.exp@19
PS1, Line 19: return 0
https://sourceware.org/ml/gdb-patches/2019-10/msg00450.html reviews a very similar patch. There I suggested using "unsupported" in these cases, since I think this is the current style.