This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] DWARF reader: Reject sections with invalid sizes
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 16 Oct 2019 12:02:11 -0400
- Subject: [review] DWARF reader: Reject sections with invalid sizes
- Auto-submitted: auto-generated
- References: <gerrit.1571240333000.I896ac3b4eb2207c54e8e05c16beab3051d9b4b2f@gnutoolchain-gerrit.osci.io>
- Reply-to: tromey at sourceware dot org, keiths at redhat dot com, gdb-patches at sourceware dot org
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127
......................................................................
Patch Set 1:
(1 comment)
Looks good but see the note. Thanks for doing this.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127/1/gdb/dwarf2read.c
File gdb/dwarf2read.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127/1/gdb/dwarf2read.c@2345
PS1, Line 2345: BFD_VMA_FMT "x) larger than the file size [in module %s]"),
BFD can set this to "I64", which isn't supported by gdbsupport/format.c. Maybe that should be fixed, but just using one of the gdb helpers like phex or whatever seems simpler... I don't see other uses of BFD_VMA_FMT in gdb.