This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Change in binutils-gdb[master]: Add initial compile command support to RISC-V port.
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Jim Wilson <jimw at sifive dot com>, gdb-patches at sourceware dot org
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Tue, 15 Oct 2019 13:07:59 -0400
- Subject: Change in binutils-gdb[master]: Add initial compile command support to RISC-V port.
- Auto-submitted: auto-generated
- References: <gerrit.1571080730000.I315ce8de7789ddf7bdd3b532f917519464941294@gnutoolchain-gerrit.osci.io>
- Reply-to: tromey at sourceware dot org, jimw at sifive dot com, andrew dot burgess at embecosm dot com, gdb-patches at sourceware dot org
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42
......................................................................
Patch Set 1:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42/1/gdb/riscv-tdep.c
File gdb/riscv-tdep.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42/1/gdb/riscv-tdep.c@3070
PS1, Line 3070: char string[64];
> I think using std::string and then just 'string += "some text";' would be preferred.
I sent a patch to change this gdbarch function to return std::string, which should make this a bit nicer.
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings