This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Change in binutils-gdb[master]: [gdb/tdep] Fix inferior call arg passing for amd64
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tom de Vries <tdevries at suse dot de>, gdb-patches at sourceware dot org
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Tue, 15 Oct 2019 12:02:12 -0400
- Subject: Change in binutils-gdb[master]: [gdb/tdep] Fix inferior call arg passing for amd64
- Auto-submitted: auto-generated
- References: <gerrit.1571043259000.Id55c74755f0a431ce31223acc86865718ae0c123@gnutoolchain-gerrit.osci.io>
- Reply-to: simon dot marchi at polymtl dot ca, tdevries at suse dot de, andrew dot burgess at embecosm dot com, gdb-patches at sourceware dot org
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31
......................................................................
Patch Set 1: Code-Review+2
> Patch Set 1:
>
> > Patch Set 1:
> >
> > (1 comment)
> >
> > So, it LGTM, but is there anybody else that you think should review it? Andrew or Alan perhaps?
>
> Andrew already reviewed by now :)
>
> Given that we're still not at +2, we could ask Alan, but he hasn't registered yet, so AFAIU I can't mark him as reviewer.
Yeah, well given the quite extensive test and the fact that Andrew also looked at it, I think it's pretty safe to merge. Alan, you are welcome to review this post-merge, of course :)
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings