This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GDB 9.1 release: Start of stabilization period ?

> Here's my wishlist:
> - [gdb/tdep] Fix 'Unexpected register class' assert in
>   amd64_push_arguments
>   https://sourceware.org/ml/gdb-patches/2019-10/msg00293.html

Fixing asserts are always nice to have for releases :-)

> - [gdb/tdep] Fix inferior call arg passing for amd64
>   https://sourceware.org/ml/gdb-patches/2019-10/msg00307.html
> - [gdb] Only force INTERP_CONSOLE ui_out for breakpoint commands in MI
>   mode
>   https://sourceware.org/ml/gdb-patches/2019-10/msg00099.html
> - [gdb/symtab] Prefer var def over decl
>   https://sourceware.org/ml/gdb-patches/2019-09/msg00161.html

These look fine in principle as well.

I can't review the patches in detail, but I did noticed on the last
one that you're adding functions without adding documentation for them.

-- 
Joel
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]