This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Change in binutils-gdb[master]: [gdb/tdep] Fix inferior call arg passing for amd64
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tom de Vries <tdevries at suse dot de>, gdb-patches at sourceware dot org
- Date: Tue, 15 Oct 2019 08:46:13 -0400
- Subject: Change in binutils-gdb[master]: [gdb/tdep] Fix inferior call arg passing for amd64
- Auto-submitted: auto-generated
- References: <gerrit.1571043259000.Id55c74755f0a431ce31223acc86865718ae0c123@gnutoolchain-gerrit.osci.io>
- Reply-to: simon dot marchi at polymtl dot ca, tdevries at suse dot de, gdb-patches at sourceware dot org
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31
......................................................................
Patch Set 1:
(1 comment)
So, it LGTM, but is there anybody else that you think should review it? Andrew or Alan perhaps?
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31/1/gdb/amd64-tdep.c
File gdb/amd64-tdep.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31/1/gdb/amd64-tdep.c@645
PS1, Line 645: theclass[1] = amd64_merge_classes (theclass[1], subclass[1]);
> Doing: […]
Ah ok that makes it clear. I thought that non-aggregate fields would always just use the first eightbyte, therefore just set subclass[0] and leave subclass[1] untouched. But that's not the case, so nevermind.
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings