This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...)
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Tom Tromey <tom at tromey dot com>, "Tom de Vries (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- Cc: gdb-patches at sourceware dot org, tdevries at suse dot de, sergiodj at sergiodj dot net, andrew dot burgess at embecosm dot com
- Date: Mon, 14 Oct 2019 20:44:29 -0400
- Subject: Re: Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...)
- Dkim-filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x9F0iUEa003522
- References: <gerrit.1571064731000.I51b689458503240f24e401f054e6583d9172ebdf@gnutoolchain-gerrit.osci.io> <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> <875zkrtd56.fsf_-_@tromey.com>
On 2019-10-14 2:06 p.m., Tom Tromey wrote:
> Hi. I've been looking at the gerrit review email.
> I'd like to suggest a way it could be improved.
>
> Consider this review:
>
> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
> Tom> File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:
>
> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74
> Tom> PS5, Line 74: pass $test
> Tom> You could do pass $gdb_test_name and get rid of the test variable.
>
> This would be a lot better if the email included more of the patch
> context. As is, it's not very readable on the list. While I do want to
> use gerrit, at the same time I think it would be nice to be able to
> following the mailing list and get a reasonably complete idea of what's
> going on.
>
> Tom
I'll take a look if it's possible to modify the templates to do so.
Simon