This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: gdb-patches at sourceware dot org
- Cc: Tom de Vries <tdevries at suse dot de>, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Mon, 14 Oct 2019 12:06:39 -0400
- Subject: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...
- Auto-submitted: auto-generated
- References: <gerrit.1571064731000.I51b689458503240f24e401f054e6583d9172ebdf@gnutoolchain-gerrit.osci.io>
- Reply-to: simon dot marchi at polymtl dot ca, sergiodj at sergiodj dot net, tdevries at suse dot de, andrew dot burgess at embecosm dot com, gdb-patches at sourceware dot org
Simon Marchi has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 )
Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................
Patch Set 5:
(1 comment)
> Patch Set 5: Code-Review+1
>
> (1 comment)
>
> LGTM, there's one nit that optionally could be fixed.
Oh right, I have seen this patch pass by but didn't think of using it there. Fixed.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74
PS5, Line 74: pass $test
> You could do pass $gdb_test_name and get rid of the test variable.
Done
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Mon, 14 Oct 2019 16:06:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom de Vries <tdevries@suse.de>
Gerrit-MessageType: comment