This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Move declaration of max_user_call_depth to header
- From: "Christian Biesinger via gdb-patches" <gdb-patches at sourceware dot org>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Christian Biesinger via gdb-patches <gdb-patches at sourceware dot org>
- Date: Sat, 12 Oct 2019 14:33:43 -0500
- Subject: Re: [PATCH] Move declaration of max_user_call_depth to header
- References: <20191010173131.96822-1-cbiesinger@google.com> <87lftr4e8s.fsf@tromey.com>
- Reply-to: Christian Biesinger <cbiesinger at google dot com>
On Fri, Oct 11, 2019 at 8:13 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> 2019-10-09 Christian Biesinger <cbiesinger@google.com>
>
> Christian> * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
> Christian> (show_user): Remove declaration of cmdlist.
> Christian> * cli/cli-cmds.h (max_user_call_depth): Declare.
> Christian> * cli/cli-script.c (execute_user_command): Remove declaration
> Christian> of max_user_call_depth.
>
> Thanks, this is ok.
Thanks, pushed.
To ssh://sourceware.org/git/binutils-gdb.git
03d0d46a0e6..cc8dee1f1c6 HEAD -> master
Christian
> Christian> /* Define all cmd_list_elements. */
> Christian> @@ -1538,7 +1538,6 @@ static void
> Christian> show_user (const char *args, int from_tty)
> Christian> {
> Christian> struct cmd_list_element *c;
> Christian> - extern struct cmd_list_element *cmdlist;
>
> Changes like this particular one qualify as obvious IMO.
Thanks, will keep that in mind, in this case I wanted to make sure I
wasn't missing anything.
Christian