This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Include xml-support.h to get a variable declaration
- From: Tom Tromey <tom at tromey dot com>
- To: "Christian Biesinger via gdb-patches" <gdb-patches at sourceware dot org>
- Cc: Christian Biesinger <cbiesinger at google dot com>
- Date: Wed, 09 Oct 2019 11:47:03 -0600
- Subject: Re: [PATCH] Include xml-support.h to get a variable declaration
- References: <20191007190631.47743-1-cbiesinger@google.com>
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> Instead of declaring xml_builtin as an extern variable
Christian> in the .c file.
Christian> gdb/gdbserver/ChangeLog:
Christian> 2019-10-07 Christian Biesinger <cbiesinger@google.com>
Christian> * server.c (get_features_xml): Remove declaration of xml_builtin
Christian> in favor of including xml-support.h.
I don't think we want to include xml-support.h in gdbserver.
Maybe the xml_builtin can be declared somewhere else instead.
It's only defined in generated files according to the comment.
Tom