This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 09/17] Introduce async-event.[ch]
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 04 Oct 2019 16:17:43 -0600
- Subject: Re: [RFC 09/17] Introduce async-event.[ch]
- References: <20190224165153.5062-1-tom@tromey.com> <20190224165153.5062-10-tom@tromey.com> <e123d54d-ad0a-7b0c-6862-30b7b9650d9b@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 2/24/19 4:51 PM, Tom Tromey wrote:
>> This patch splits out some gdb-specific code from event-loop, into new
>> files async-event.[ch]. Strictly speaking this code could perhaps be
>> put into common/, but because gdbserver does not currently use it, it
>> seemed better, for size reasons, to split it out.
Pedro> Seems fine. Going forward, I wonder whether we'll split event loop
Pedro> things into more files, and whether using a name prefix like "event-loop-"
Pedro> or "el-", like "el-async-event.[ch]" would help keeping things a bit
Pedro> closer together. Just a thought; not a request.
I don't have plans to do anything more in this area, and I didn't feel
quite strongly enough about it to do the renaming, so I've just left it
as-is.
I somewhat wish we could remove all this code in favor of a pre-canned
event loop solution, like libevent. Too bad dependencies are such a
pain.
Tom