This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 17/17] Simplify gdbserver's serial event handling
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 04 Oct 2019 16:08:41 -0600
- Subject: Re: [RFC 17/17] Simplify gdbserver's serial event handling
- References: <20190224165153.5062-1-tom@tromey.com> <20190224165153.5062-18-tom@tromey.com> <a87c195a-a1ed-1143-de2a-d8b363cb706d@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 2/24/19 4:51 PM, Tom Tromey wrote:
>> Currently, when gdbserver handles a serial event, it also calls
>> 'reschedule' to install a timer that is then used to process any data
>> that remains after the previous packet was processed.
>>
>> It seemed better to me to simply have the file descriptor callback
>> loop, processing packets until complete.
Pedro> I would rather not do this change, because it potentially starves other
Pedro> event sources. I've had to fix starvation issues like that in several
Pedro> places in gdb throughout the years -- see url I pointed that justifying
Pedro> need for async serial events, random_pending_event_thread in
Pedro> infrun.c, etc.
I have dropped it.
Tom