Re: [PATCH v3] gdb: CTF support

[Weimin Pan <weimin dot pan at oracle dot com>]

On 10/3/2019 6:10 PM, Simon Marchi wrote:
> On 2019-10-03 6:56 p.m., Weimin Pan wrote:
>> [Changes from v2:
>>  - Address Simon Marchi's comments, mainly:
>>    * Use gdb::unique_xmalloc_ptr<> to minimize the manual memory 
management.
>>    * Modify create_partial_symtab to handle multiple-CUs correctly.
>>    * Improve defining/using ctf_context_t and field_info structs.
>>    * Conform to GNU's coding standards.
>>
>> ....
>> This patch has missing features and limitations which we will add and
>> address in the future patches.
>
> Hi Weimin,
>
> 1. Could you please split the renaming of ctf (the trace format) to 
tracectf to its
> own patch, just before this patch (send them as a patch series)?  It 
will keep this
> patch more focused on its main topic.

Hi Siomn,

FYI, just posted the patch series.

>
> 2. When applying the patch, git told me:
>
> .git/rebase-apply/patch:1079: trailing whitespace.
>       {
> .git/rebase-apply/patch:1083: trailing whitespace.
>       }
> .git/rebase-apply/patch:1824: trailing whitespace.
>
> .git/rebase-apply/patch:1889: trailing whitespace.
>
> .git/rebase-apply/patch:1894: trailing whitespace.
>
> Can you try to fix those?  One way of finding the offenders is to do 
"git show"
> and look for trailing spaces by searching for `. $` in less.

Fixed.

>
> 3. I think the binutils patchset has been merged now?  Could you 
please rebase
> on the latest master and force-push your users/weimin/ctf branch?

Yes, binutils has been pushed yesterday. Would you please take a look at
the patch series and let me know if you have any comments.

>
>> gdb/ChangeLog
>> +2019-10-03  Weimin Pan  <weimin.pan@oracle.com>
>> +
>> +    * gdb/ctfread.c: New file.
>> +    * gdb/ctfread.h: New file.
>> +    * gdb/elfread.c: Include ctfread.h.
>> +    (struct elfinfo text_p): New member ctfsect.
>> +    (elf_locate_sections): Mark CTF section.
>> +    (elf_symfile_read): Call elfctf_build_psymtabs.
>> +    * gdb/Makefile.in (LIBCTF): Add.
>> +    (CLIBS): Use it.
>> +    (CDEPS): Likewise.
>> +    (DIST): Add ctfread.c.
>> +    * gdb/tracectf.h: Rename, was gdb/ctf.h
>> +    * gdb/ctf.c: Replace ctf.h with tracectf.h
>> +    * gdb/tracefile.c: Likewise
>> +    * gdb/tracepoint.c: Remove unused include ctf.h
>> +    * gdb/mi/mi-main.c: Likewise
>
> Drop all the gdb/ prefixes from this list, as we want all entries to 
be relative
> to the ChangeLog file they appear in.

Done.

>
>> +    * Makefile.def (dependencies): Add all-libctf to all-gdb
>> +    * Makefile.in: Add "all-gdb: maybe-all-libctf"
>
> Changes made to the top-level Makefile.def/Makefile.in will go in the 
top-level
> ChangeLog.
>
> Simon

Thanks,
Weimin