This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] gdb: Split print_symbol_info into two parts
- From: Simon Marchi <simark at simark dot ca>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 3 Oct 2019 21:50:06 -0400
- Subject: Re: [PATCH 2/3] gdb: Split print_symbol_info into two parts
- References: <cover.1569539198.git.andrew.burgess@embecosm.com> <c53834289016a8394c1b61ba4c9e3fde88e2acc0.1569539198.git.andrew.burgess@embecosm.com>
> diff --git a/gdb/symtab.h b/gdb/symtab.h
> index 1f0fc62a657..f5da8229f2f 100644
> --- a/gdb/symtab.h
> +++ b/gdb/symtab.h
> @@ -2029,6 +2029,14 @@ extern std::vector<symbol_search> search_symbols (const char *,
> int,
> const char **,
> bool);
> +
> +/* Helper for print_symbol_info, return a string that describes SYM.
> + BLOCK is either GLOBAL_BLOCK or STATIC_BLOCK, and KIND is the type of
> + symbol that was searched for. */
Just a nit about this comment: I would not say that it's a helper for
print_symbol_info, which isn't an exported function. I think it's odd
to say that an exported function is a helper for an non-exported function
(where both are implemented in the same file).
Simon