This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] gdb: CTF support

From: Wei-min Pan <weimin dot pan at oracle dot com>
To: Simon Marchi <simark at simark dot ca>, gdb-patches at sourceware dot org
Date: Thu, 3 Oct 2019 10:58:08 -0700
Subject: Re: [PATCH v2] gdb: CTF support
References: <1564530195-27659-1-git-send-email-weimin.pan@oracle.com> <5377c457-52b0-583d-15b5-47024eae1f48@simark.ca> <895f47d4-3e01-4d5a-474b-43dd2dd037b4@oracle.com> <0fe82814-46b8-79c2-6a25-5f5d51b158e1@simark.ca> <1055d18f-9e5c-3344-114a-3777876c9c63@oracle.com> <3a67839f-73d0-06ed-4140-073306fc618d@simark.ca>


On 10/3/2019 5:40 AM, Simon Marchi wrote:

On 2019-10-02 7:09 p.m., Wei-min Pan wrote:

It doesn't seem using gdb::unique_xmalloc_pointer is appropriate in
these cases
because we want to keep these symbol/type names around in the symbol table.

I mean, instead of calling `free` by hand, that copy could be managed with
a gdb::unique_xmalloc_pointer.  The name duplicated into the symbol table
won't change.

But the `free` call is needed to free up space allocated by libctf'sctf_type_aname_raw.

Simon

Follow-Ups:
- Re: [PATCH v2] gdb: CTF support
  - From: Simon Marchi

References:
- Re: [PATCH v2] gdb: CTF support
  - From: Weimin Pan
- Re: [PATCH v2] gdb: CTF support
  - From: Simon Marchi
- Re: [PATCH v2] gdb: CTF support
  - From: Wei-min Pan
- Re: [PATCH v2] gdb: CTF support
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]