This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 07/23] Delete unnecessary code from kill_command
- From: "Aktemur, Tankut Baris" <tankut dot baris dot aktemur at intel dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 1 Oct 2019 13:28:20 +0000
- Subject: Re: [PATCH 07/23] Delete unnecessary code from kill_command
- References: <20190906232807.6191-1-palves@redhat.com> <20190906232807.6191-8-palves@redhat.com> <B98F7326B8E238409968F562D326E1A90D072C2C@IRSMSX103.ger.corp.intel.com>
* On October 1, 2019 12:19 PM, Aktemur, Tankut Baris wrote:
>
> Hi,
>
> * On September 7, 2019 1:28 AM, Pedro Alves wrote:
> >
> > diff --git a/gdb/infcmd.c b/gdb/infcmd.c
> > index d7a7e6f933..a12dba23aa 100644
> > --- a/gdb/infcmd.c
> > +++ b/gdb/infcmd.c
> > @@ -2503,20 +2503,6 @@ kill_command (const char *arg, int from_tty)
> > printf_unfiltered (_("[Inferior %d (%s) killed]\n"),
> > infnum, pid_str.c_str ());
> >
> > - /* If we still have other inferiors to debug, then don't mess with
> > - with their threads. */
> > - if (!have_inferiors ())
> > - {
> > - init_thread_list (); /* Destroy thread info. */
>
> Removing 'init_thread_list' skips re-initialization of the
> 'highest_thread_num' global back to zero. In turn, this causes the
> following failure:
>
> FAIL: gdb.arch/i386-mpx-simple_segv.exp: print nopass stop: display
>
Please ignore this. The failure is caused by another patch, not this one.
Regards,
-Baris
> because the output becomes
>
> Thread 1 "i386-mpx-simple" received signal SIGSEGV
>
> instead of
>
> Program received signal SIGSEGV
>
> Regards,
> -Baris
>
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928