This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] OpenMP parallel region scope tests
- From: Tom Tromey <tom at tromey dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 30 Sep 2019 10:22:40 -0600
- Subject: Re: [PATCH 2/2] OpenMP parallel region scope tests
- References: <20190822171408.28271-1-kevinb@redhat.com> <20190822171408.28271-3-kevinb@redhat.com>
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
Kevin> Add tests which check for accessibility of variables from within
Kevin> various OpenMP parallel regions.
I don't know anything about OpenMP, so I didn't read new .c file.
I'm not especially concerned about it though.
Kevin> +if {[gdb_compile_openmp "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != ""} {
Over-long line.
Kevin> +if {[info procs openmp_setup] != ""} {
Kevin> + if {[openmp_setup $binfile] != ""} {
Kevin> + return -1
Does this need a call to "untested"?
The rest seemed fine to me.
Tom