This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5] Improve ptrace-error detection on Linux targets
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Eli Zaretskii <eliz at gnu dot org>, Ruslan Kabatsayev <b7 dot 10110111 at gmail dot com>
- Date: Thu, 26 Sep 2019 18:48:44 +0100
- Subject: Re: [PATCH v5] Improve ptrace-error detection on Linux targets
- References: <20190819032918.3536-1-sergiodj@redhat.com> <20190926042155.31481-1-sergiodj@redhat.com> <87d0fngdyx.fsf@tromey.com>
On 9/26/19 6:32 PM, Tom Tromey wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> Changes from v4:
> Sergio> - Don't add 'dont_throw' optional argument to gdb_dlopen; use
> Sergio> conventional try..catch.
>
> Sergio> - Use snprintf when printing to 'own_buf' and make sure we don't
> Sergio> overflow the buffer.
>
> Thank you for doing this.
> I think this is ok, please check it in.
Please give me a bit to review before merging. I think I spotted an issue,
but I haven't had a chance to take a look at it since before Cauldron.
Thanks,
Pedro Alves