This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/8] Handle copy relocations
- From: Tom Tromey <tromey at adacore dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>, Tom Tromey <tromey at adacore dot com>, gdb-patches at sourceware dot org
- Date: Thu, 19 Sep 2019 12:27:58 -0600
- Subject: Re: [PATCH v2 2/8] Handle copy relocations
- References: <20190801170412.5553-1-tromey@adacore.com> <20190801170412.5553-3-tromey@adacore.com> <20190821153528.GH6076@embecosm.com> <87ftlul4ed.fsf@tromey.com> <20190822084129.GK6076@embecosm.com> <87zhj0qiy1.fsf@tromey.com>
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Andrew> I guess I'm thinking that we could merge the core of
Andrew> lookup_minimal_symbol_text and lookup_minimal_symbol_linkage (or
Andrew> _data), and just pass in a comparison function to check for either
Andrew> text or data symbols.
Tom> Sounds good, I'll try that. There is already a separate debug iterator,
Tom> so maybe that can be used as well.
I looked at this, but there isn't really that much to share.
IMO callbacks tend to obfuscate the code. So I think I'd rather not do
that, if that's ok with you.
Maybe introducing an iterator over minimal symbols, given a hash, would
simplify things a bit. But, that's not really much of a savings.
Tom