This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: remove local extern declaration of cli_styling
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Sep 2019 10:18:43 -0600
- Subject: Re: [PATCH] gdb: remove local extern declaration of cli_styling
- References: <20190918030533.365417-1-simon.marchi@polymtl.ca>
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> * ui-file.c: Include cli/cli-style.h.
Simon> (term_cli_styling): Remove cli_styling declaration.
Thanks for doing this.
I think as a rule it's best to always have declarations in a header and
never in the .c code. That way they can be checked against the
definition.
Tom