This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 0/3] Fix stop-on-solib event failures
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Mon, 2 Sep 2019 13:20:22 +0000
- Subject: Re: [PATCH v2 0/3] Fix stop-on-solib event failures
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6vZgB42dhqUobo7HPqgpymAMpz9cZfkxWlFR17XHHw=; b=EBd1Yaa9ddKnr/2CGeDJCosOm0NkL7X67U2oA8AMy/DpTNzgu4JipS/cnrGsHLo3MW8ONjZAHWkBBwS5nJP/ROX7tIX6jAHzp3sFC5VxwNNwYu5QbhQJDCRVdPxu+0LU8U0fZblCSPd7E5a3XfcrU3VYPtkt+9renvCPIEWTMmYEr7djlAmdAI2dXIAPC6qfTyCoGhS95uMq0aC0Vw4ZkernbgYr8RdyumXFxrd9/ryrFbbqTnhoBJId2jEUr+8gPjlQc8srD6SHkZxM1YMhpmikNy/cbTAnUSlQSCzyhz8Z2bTs2QGhZtceNOHtNrkDUMZxhR+A3V++XamZ3mSivQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCtN5Dc9imGNj6tuOZdxWYbHUXjMpgljKY1H/KveiuMqLwM0fUK30/L0zDDNkF846hOGNIADB/1JYA5pJwKGiAwEiyRLZD+PZvY8o8XDHJHUarL1xjQmi39vFB875UhbU5cuGZLfPVnnKBA8HDmKoiNy0U3HtO24Xbo07XuiV1Fvg7bxbLCSAQKKV3Ckwt67C4JtECqrtoICdOJmXRA9kgwZtgL88p9EZnwDYpe1dz4i4hkZ226iS+aTmhNf4TofLzKbkhAfkbkquHJdYOlSV0+ZM01Bk4CN2c63HNJKKynOEZQVr9nJAppb9kr7t+efl+I3Br/YqN0PPkvawMjMhg==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan dot Hayward at arm dot com;
- References: <20190821155816.45504-1-alan.hayward@arm.com> <20190830155151.GA11044@blade.nx>
> On 30 Aug 2019, at 16:51, Gary Benson <gbenson@redhat.com> wrote:
>
> Hi Alan,
>
> Alan Hayward wrote:
>> On some Arm targets (namely the buildbot Arm Docker setup) placing
>> breakpoints on just the solib dynamic probes will cause the target
>> process to not stop. This is due to the probes being invalid - see
>> link in 3/3 for more details.
>>
>> Fix is to fully validate the probes before using the,.
>>
>> Patches 1 and 2 are code refactors. The actual fix is in patch 3.
>
> The code looks good to me, my only caveat being that I think we're
> supposed to wrap lines at 72 columns (unless that changed) and some
> lines in your patches seem too long. I noticed it in comments, but
> possibly it's in code too. With that fixed (or, not fixed if we
> don't wrap at 72 columns any more) I'd say this is good to commit.
> Thank you for doing the work!
>
I’ve always kept within 80. Double checking the coding standards, it has:
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Column_limits
I’ve always wondered why there’s a lot of code that wraps earlier and
that explains why. (personally I’d prefer even longer, but that’s just me).
Anyway, pushed patch to head.
Thanks!
Alan.