This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 0/3] Fix stop-on-solib event failures


Hi Alan,

Alan Hayward wrote:
> On some Arm targets (namely the buildbot Arm Docker setup) placing
> breakpoints on just the solib dynamic probes will cause the target
> process to not stop.  This is due to the probes being invalid - see
> link in 3/3 for more details.
> 
> Fix is to fully validate the probes before using the,.
> 
> Patches 1 and 2 are code refactors. The actual fix is in patch 3.

The code looks good to me, my only caveat being that I think we're
supposed to wrap lines at 72 columns (unless that changed) and some
lines in your patches seem too long.  I noticed it in comments, but
possibly it's in code too.  With that fixed (or, not fixed if we
don't wrap at 72 columns any more) I'd say this is good to commit.
Thank you for doing the work!

Cheers,
Gary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]