This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 0/3] Fix stop-on-solib event failures
- From: Gary Benson <gbenson at redhat dot com>
- To: Alan Hayward <Alan dot Hayward at arm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Fri, 30 Aug 2019 16:51:53 +0100
- Subject: Re: [PATCH v2 0/3] Fix stop-on-solib event failures
- References: <20190821155816.45504-1-alan.hayward@arm.com>
Hi Alan,
Alan Hayward wrote:
> On some Arm targets (namely the buildbot Arm Docker setup) placing
> breakpoints on just the solib dynamic probes will cause the target
> process to not stop. This is due to the probes being invalid - see
> link in 3/3 for more details.
>
> Fix is to fully validate the probes before using the,.
>
> Patches 1 and 2 are code refactors. The actual fix is in patch 3.
The code looks good to me, my only caveat being that I think we're
supposed to wrap lines at 72 columns (unless that changed) and some
lines in your patches seem too long. I noticed it in comments, but
possibly it's in code too. With that fixed (or, not fixed if we
don't wrap at 72 columns any more) I'd say this is good to commit.
Thank you for doing the work!
Cheers,
Gary