This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR win32/24284: tcp_auto_retry doesn't work in MinGW
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Cc: Bernhard Wodok <barto at gmx dot net>, Paul Carroll <pcarroll at codesourcery dot com>
- Date: Thu, 29 Aug 2019 13:15:41 +0100
- Subject: Re: [PATCH] Fix PR win32/24284: tcp_auto_retry doesn't work in MinGW
- References: <20190827155013.31610-1-sergiodj@redhat.com>
On 8/27/19 4:50 PM, Sergio Durigan Junior wrote:
> This was reported by Bernhard Wodok, along with a patch to fix the
> issue. I adjusted the patch a bit, and I'm submitting the patch on
> his behalf.
>
> According to Bernhard, the issue can be reproduced by doing:
>
> 1. start gdb
> 2. enter 'target remote :2345'
> 3. observe that it throws a "connection refused" error immediately
> instead of waiting and throwing a timeout error
>
> I.e., I believe it can be reproduced by our current tests, which is
> why I'm not proposing any extra tests here (well, I don't use nor have
> any Windows system to test this, so...).
>
> The problem happens because we call 'gdb_select' passing 0 as its
> first argument,
I assume this is from wait_for_connect? Please mention that above.
Must be, because I just now noticed that gdb_usleep is now dead code.
The comment in wait_for_connect is quite curious, kind of implies that
this worked on Windows at some point:
/* Use gdb_select here, since we have no file descriptors, and on
Windows, plain select doesn't work in that case. */
n = gdb_select (0, NULL, NULL, NULL, &t);
> --- a/gdb/mingw-hdep.c
> +++ b/gdb/mingw-hdep.c
> @@ -64,6 +64,17 @@ gdb_select (int n, fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
> int num_ready;
> size_t indx;
>
> + if (n == 0)
> + {
> + /* The MS API says that the first argument to
> + WaitForMultipleObjects cannot be zero. That's we just use
> + a regular Sleep here. */
The sentence:
"That's we just use a regular Sleep here."
is non-grammatical. Missing a "why" in "That's why" ?
OK with that fixed.
Thanks,
Pedro Alves