This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove some variables in favor of using gdb::optional


On 2019-08-23 4:23 p.m., Pedro Alves wrote:
> Sorry for the delayed nit, but the first time I didn't really pay attention
> the the enumerator names you were using.  Reading back, I notice that you
> used "dynamic".  I don't know what that means here?  Don't you mean
> "external", as opposed to static?  Like, wouldn't this be more to the point?
> 
>   enum {
>     symbol_linkage_unknown,
>     symbol_linkage_static,
>     symbol_linkage_extern,
>   } symbol_linkage = symbol_linkage_unknown;

Oh yes of course, I was confused static/extern with static/dynamic.  I'll use that, thanks.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]