This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[testsuite, obvious] Fix paste-o in examine-backward.exp


I've checked in the attached patch to fix a clear cut-and-paste error in gdb.base/examine-backward.exp due to a change in a previous commit. The testcase used to have the correct regexp before that, and I've verified this fix works by testing on nios2-elf.

-Sandra
commit d8f9e51c361dfb53de3eca8d84f8938380af60ff
Author: Sandra Loosemore <sandra@codesourcery.com>
Date:   Thu Aug 15 18:15:16 2019 -0700

    Fix paste-o in examine-backward.exp.
    
    This patch fixes a paste-o that was introduced in commit
    c8ad9b9a31aa3e6039567fc1f152dd454c946d5f.  Previously the regexp for
    the "examine 3 bytes backward from ${address_zero}" test correctly
    matched 3 "${byte}" patterns, but in that commit the 6-byte regexp
    from the previous test was mistakenly repeated here instead.
    
    2019-08-15  Sandra Loosemore  <sandra@codesourcery.com>
    
    	gdb/testsuite/
    	* gdb.base/examine-backward.exp: Correct regexp for
    	"examine 3 bytes backward from ${address_zero}".

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 294243a..25eeefc 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-15  Sandra Loosemore  <sandra@codesourcery.com>
+
+	* gdb.base/examine-backward.exp: Correct regexp for
+	"examine 3 bytes backward from ${address_zero}".
+
 2019-08-15  Tom Tromey  <tom@tromey.com>
 
 	* gdb.tui/empty.exp: Enable resizing tests.
diff --git a/gdb/testsuite/gdb.base/examine-backward.exp b/gdb/testsuite/gdb.base/examine-backward.exp
index 9e1e64c..c3dbf04 100644
--- a/gdb/testsuite/gdb.base/examine-backward.exp
+++ b/gdb/testsuite/gdb.base/examine-backward.exp
@@ -132,7 +132,7 @@ with_test_prefix "address zero boundary" {
 
     set test "examine 3 bytes backward from ${address_zero}"
     gdb_test_multiple "x/-3x ${address_zero}" "$test" {
-	-re "0x\[0-9a-f\]+fd.*:${byte}${byte}${byte}${byte}${byte}${byte}.*\[\r\n\]*$gdb_prompt $" {
+	-re "0x\[0-9a-f\]+fd.*:${byte}${byte}${byte}.*\[\r\n\]*$gdb_prompt $" {
 	    pass $test
 	}
 	-re "0x\[0-9a-f\]+fd.*:\tCannot access memory at address 0x\[0-9a-f\]+fd.*\[\r\n\]*$gdb_prompt $" {

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]