This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Rename internal Python functions to start with an underscore


On Thu, Aug 15, 2019 at 2:14 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Thank you for the patch.
>
> Christian> 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
> Christian>      leading underscore.
> Christian>      (GdbOutputErrorFile): Likewise.
> Christian>      (global scope): Adjust constructor calls to GdbOutput{,Error}File
> Christian>      accordingly.
> Christian>      (execute_unwinders): Rename to have a leading underscore.
> Christian>      (auto_load_packages): Likewise.
> Christian>      (global scope): Adjust call to auto_load_packages accordingly.
> Christian>      (GdbSetPythonDirectory): Likewise.
> Christian>      * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
> Christian>      instead of execute_unwinders.
>
> Christian> gdb/testsuite/ChangeLog:
>
> Christian> 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * gdb.python/python.exp: Expect a leading underscore on
> Christian>      GdbOutput{,Error}File.
>
> I'm maybe mildly concerned that some code out there could be using one
> of these, but on the other hand these are all internal.  So, I think
> this is ok.

Thanks, pushed.

Christian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]