This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Rename internal Python functions to start with an underscore
- From: "Christian Biesinger via gdb-patches" <gdb-patches at sourceware dot org>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Christian Biesinger via gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 15 Aug 2019 14:23:06 -0500
- Subject: Re: [PATCH] Rename internal Python functions to start with an underscore
- References: <20190815164601.114915-1-cbiesinger@google.com> <87ftm2tf5o.fsf@tromey.com>
- Reply-to: Christian Biesinger <cbiesinger at google dot com>
On Thu, Aug 15, 2019 at 2:14 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Thank you for the patch.
>
> Christian> 2019-08-15 Christian Biesinger <cbiesinger@google.com>
>
> Christian> * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
> Christian> leading underscore.
> Christian> (GdbOutputErrorFile): Likewise.
> Christian> (global scope): Adjust constructor calls to GdbOutput{,Error}File
> Christian> accordingly.
> Christian> (execute_unwinders): Rename to have a leading underscore.
> Christian> (auto_load_packages): Likewise.
> Christian> (global scope): Adjust call to auto_load_packages accordingly.
> Christian> (GdbSetPythonDirectory): Likewise.
> Christian> * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
> Christian> instead of execute_unwinders.
>
> Christian> gdb/testsuite/ChangeLog:
>
> Christian> 2019-08-15 Christian Biesinger <cbiesinger@google.com>
>
> Christian> * gdb.python/python.exp: Expect a leading underscore on
> Christian> GdbOutput{,Error}File.
>
> I'm maybe mildly concerned that some code out there could be using one
> of these, but on the other hand these are all internal. So, I think
> this is ok.
Thanks, pushed.
Christian