This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host
On 2019-08-15 10:37 a.m., Sandra Loosemore wrote:
>
> I did consider that, but the existing previous bit in that file is just
>
> # This test can only be run on targets which support DWARF-2 and use gas.
> if {![dwarf2_support]} {
> return 0
> }
>
> (which also appears in almost all the other gdb.dwarf2/*.exp files) so I thought it would be locally consistent to just return quietly. Is the policy to use "untested" for host issues but not target properties, maybe? I'll do whatever conforms to recommended practice here, of course.
Personally, any time a test is skipped for whatever reason, I'd like to see some "UNTESTED"
or "UNSUPPORTED" in the .sum file, to at least know the test existed and was skipped (along
with the reason), rather than just it being omitted.
I don't know if we have an "official" recommended practice here, this is just my opinion.
The patch LGTM in both cases, so I'll let you choose :).
Simon