This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host
- From: Sandra Loosemore <sandra at codesourcery dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 13 Aug 2019 16:29:18 -0600
- Subject: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host
- Ironport-sdr: C8kLltDZ91e5z5jeXAEVb58nX/zfUdUBKEADmL7zyyHt5WgnUMTv5962Ni+ZYIgMiuZgg5pTkU 6ZZWj8DxMoVxQawOybJfeSKtCcG6bIVozKdygJEac3OPkAwdU7kHOj36rxb2A+y65PQFd0igZV HM9Zx7pO/UyFXWvrMa6IDuzzMXPssbFVlN2heAQn5tQFczGTf94Hbzv69BkUHnnvLFX1VwzXiU MM5GQrupNfJBcJAxnMPlE1znmrOYzLhI1+tsyoJFfYeLzQzXhRht0zlT6nWPZDTy57E8FnL2Me 9sk=
- Ironport-sdr: 5oWTA1IzjP+lvcVJef7hwfFttJ/se2d06B8oo6COCX1gga9UU69zjNQTrkSbdYM1y38Y1QvYsN DIpWKHTNZt+LRNd7sKFs2mRy01frmmVwZwtF59DqMOIuH3MM210wbQpn7T3dah/+3KrTrAUnnp /PLTw6OSwHvrQSgtIDCsUe50/OJMC2yVoGwTpeRE8rOXKh8dONYA/Z9kSR2QSk0xe+cg8qjSmZ I6ReuJoGGE5dNkXTGXQJYrfDBJywD56AKQb1ZmZRpcYJIhJf/syZE2isaPt2PjL1OJGFGKC7W1 JhQ=
This is yet another testsuite fix to clean up results on remote Windows
host.
For this testcase, I did consider trying to fix it rather than just
disabling it for remote host, but it looked like it was going to be an
awful lot of work and trial-and-error (it has almost no comments to
explain what it is trying to test, or how it is getting there). I think
it is at least an incremental improvement to document that it isn't
expected to work as-is on remote host. And disabling it does get rid of
33 completely bogus FAILs. :-P
OK?
-Sandra
commit b1c596ea64186661fc17b9e7b410b95ef4b9cc2e
Author: Sandra Loosemore <sandra@codesourcery.com>
Date: Tue Aug 13 15:13:13 2019 -0700
Disable dw2-dir-file-name.exp on remote and/or Windows host.
This test has many hardwired assumptions that pathnames on build and
host are the same, and that POSIX pathname syntax is used. This
results in dozens of failures on a remote Windows host. Fixing these
assumptions would involve nontrivial rewrites; meanwhile, let's make
the test results reflect the reality that this testcase isn't supported
on remote host.
2019-08-13 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite/
* gdb.dwarf2/dw2-dir-file-name.exp: Skip on remote or
Windows host.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 38689c1..65fdc6e 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2019-08-13 Sandra Loosemore <sandra@codesourcery.com>
+ * gdb.dwarf2/dw2-dir-file-name.exp: Skip on remote or
+ Windows host.
+
+2019-08-13 Sandra Loosemore <sandra@codesourcery.com>
+
* gdb.base/batch-preserve-term-settings.exp
(test_terminal_settings_preserved_after_sigterm): Skip on Windows.
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
index 246b4af..2933df9 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
@@ -19,6 +19,12 @@ if {![dwarf2_support]} {
return 0
}
+# This test has hard-wired assumptions that host and build filenames are
+# the same, and assumes POSIX pathname syntax.
+if { [is_remote host] || [ishost *-*-mingw*] } {
+ return 0
+}
+
# Find length of addresses in bytes.
if {[is_64_target]} {
set addr_len 8