This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] Add obstack_strdup overload taking a std::string
On Sat, 3 Aug 2019 20:51:09 -0600
Tom Tromey <tom@tromey.com> wrote:
> This adds an overload overload that takes a std::string, and changes a
s/overload overload/obstack_strdup overload/
> few spots in gdb to use it.
>
> 2019-08-03 Tom Tromey <tom@tromey.com>
>
> * symfile.c (reread_symbols): Use obstack_strdup.
> * stabsread.c (read_type): Use obstack_strdup.
> * gdb_obstack.h (obstack_strdup): New overload.
> * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
> (create_dwo_unit_in_dwp_v2, build_error_marker_type)
> (dwarf2_canonicalize_name): Use obstack_strdup.
> * dbxread.c (read_dbx_symtab): Use obstack_strdup.
> * cp-support.c (inspect_type, replace_typedefs_qualified_name):
> Use obstack_strdup.
Nice. LGTM, except for the one nit noted above.
Kevin