This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] AArch64: Allow additional sizes in prologue
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 6 Aug 2019 08:58:37 +0000
- Subject: Re: [PATCH] AArch64: Allow additional sizes in prologue
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MnfYJK758wonN3geIXqdkfOzANT00g7JKirQczqpjxY=; b=mJq1eVGnZOy8ptonghV6mz/QZUue4JHSk5M8Jde5XB52iZKh4eKYWRx7Nvcz9R3XqER487msi3BbtmxEG1T9eZ6saMYtzPHSC5bDZahP2vYlOaIpEX/vtuZdNEgQQpH6s4Ii+DmtXAy5bPHt7a+VI6s3MG8KBTwaFOQHFwYNe/cu76ziE90T5dPmqQ6onOmSa7X4FNhC/knoezK5eEzy6a5bVJNxV1JIomuz5nSWe5Io/BocDUy+i6frwee3qNXH6X2h+xZNubCcx8y3PJg4Y/frNsbWbYivgEUFvcoXL4gE+uFSAyhDdoHNlMJmFdjClv7rP1rkMohCDjy8XmYEGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PDIqTQs+LocFk6MHPVtgIlKD0hAmoLHETZCOnRte/+PS/E/15/P616I/tpWqsLPe4IGYm08YVsAlv+ik4IFCciU2Uv+7V/krHpTsEwardKM2x9XeQvBMteAOVI5WPG4cchhtu3a7ptGYyqQ9XqjsPa50gWdNlh5w6MhDrfMz3g9y7SXvZ58Xxxr6fn+ACdm0zH6Z9S/7oDwhGTbjSp5+E60nRcP05T2r4Ru04ARBE0ci3KIb6JqnS3pOXDYd1nswC69OPC/HISADVZaLki3TiZjffFik2983BbPHDn4ceX63h6r81lj2z8zGXbUJCLAIIHiZZdyzKcOb2lg1id+9Dg==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan dot Hayward at arm dot com;
- References: <20190805124152.26127-1-alan.hayward@arm.com> <8736ifcxu8.fsf@tromey.com>
> On 5 Aug 2019, at 18:43, Tom Tromey <tom@tromey.com> wrote:
>
>>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:
>
> Alan> When saving registers to the stack at the start of a function, not all state
> Alan> needs to be saved. For example, only the first 64bits of float registers need
> Alan> saving. However, a program may choose to store extra state if it wishes,
> Alan> there is nothing preventing it doing so.
>
> Alan> The aarch64_analyze_prologue will error if it detects extra state being
> Alan> stored. Relex this restriction.
>
> I don't know anything about AArch64, so I can't really comment on the
> content of the patch, but I did happen to see a nit:
>
> Alan> stack.store (pv_add_constant (regs[rn],
> Alan> inst.operands[1].addr.offset.imm),
> Alan> - is64 ? 8 : 4, regs[rt]);
> Alan> + size, regs[rt]);
>
> ...this addition looked mis-indented to me.
Thanks.
I probably missed that because the correct formatting looks horrible:
stack.store (pv_add_constant (regs[rn],
inst.operands[1].addr.offset.imm),
size, regs[rt]);
Instead, I can update it to the following
stack.store (
pv_add_constant (regs[rn], inst.operands[1].addr.offset.imm),
size, regs[rt]);
>
> Tom