This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Increase timeout in gdb.mi/list-thread-groups-available.exp
- From: Simon Marchi <simon dot marchi at efficios dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom de Vries <tdevries at suse dot de>, Simon Marchi <simon dot marchi at efficios dot com>
- Date: Thu, 1 Aug 2019 10:38:55 -0400
- Subject: [PATCH] Increase timeout in gdb.mi/list-thread-groups-available.exp
- Dkim-filter: OpenDKIM Filter v2.10.3 mail.efficios.com 2590B26A3CF
Running
make check-read1 TESTS="gdb.mi/list-thread-groups-available.exp"
on my machine results in timeout failures. Running it while having
`tail -F testsuite/gdb.log` on the side shows that the test is never
really blocked, it is just slow at consuming the large output generated
by `-list-thread-groups --available` (which lists all the processes on
the system).
If I increase the timeout to a large value, the test passes in ~30
seconds (compared to under 1 second normally).
Increase the timeout for the particular mi_gdb_test that is long to
execute under read1. The new timeout value is a bit arbitrary. The
default timeout is 10 seconds, so I set the new timeout to be
"old-timeout * 10", so 100 seconds in the typical case.
gdb/testsuite/ChangeLog:
PR gdb/24863
* gdb.mi/list-thread-groups-available.exp: Increase timeout for
-list-thread-groups --available test.
---
.../gdb.mi/list-thread-groups-available.exp | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
index 792c3bac8962..c8486ce1f3d1 100644
--- a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
+++ b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
@@ -54,10 +54,18 @@ set cores_re "cores=\\\[(\"$decimal\"(,\"$decimal\")*)?\\\]"
# List all available processes.
set process_entry_re "{${id_re},${type_re}(,$description_re)?(,$user_re)?(,$cores_re)?}"
-mi_gdb_test \
- "-list-thread-groups --available" \
- "\\^done,groups=\\\[${process_entry_re}(,$process_entry_re)*\\\]" \
- "list available thread groups"
+save_vars { timeout } {
+ # Increase the timeout: when running with `make check-read1`, this can take
+ # a bit of time, as there is a lot of output generated, hence a lot of read
+ # syscalls.
+ set timeout [expr $timeout * 10]
+
+ mi_gdb_test \
+ "-list-thread-groups --available" \
+ "\\^done,groups=\\\[${process_entry_re}(,$process_entry_re)*\\\]" \
+ "list available thread groups"
+}
+
# List specific processes, make sure there are two entries.
set spawn_id_1 [remote_spawn target $binfile]
--
2.22.0