This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] Change SYMBOL_VALUE_ADDRESS to be an lvalue
- From: Tom Tromey <tromey at adacore dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: Tom Tromey <tromey at adacore dot com>, gdb-patches at sourceware dot org
- Date: Tue, 23 Jul 2019 09:53:02 -0600
- Subject: Re: [PATCH 1/4] Change SYMBOL_VALUE_ADDRESS to be an lvalue
- References: <20190627145235.21222-1-tromey@adacore.com> <20190627145235.21222-2-tromey@adacore.com> <290eda910e16f817e2ba298b17db7254@polymtl.ca>
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> On 2019-06-27 10:52, Tom Tromey wrote:
>> This changes SYMBOL_VALUE_ADDRESS to be an lvalue. The symbol readers
>> generally assign using this, so this also introduces
>> SET_SYMBOL_VALUE_ADDRESS and updates the readers. Making this change
>> is useful in a subsequent patch, which redefined SYMBOL_VALUE_ADDRESS.
Simon> Is the title (and commit message) backwards? SYMBOL_VALUE_ADDRESS(x)
Simon> is currently an lvalue, and you are making it a not-lvalue, no?
Yeah, I meant rvalue. I've updated the patch to fix this.
Tom