This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use block_enum instead of int for better typesafety


On Fri, Jul 19, 2019 at 9:38 AM Christian Biesinger
<cbiesinger@google.com> wrote:
>
> On Fri, Jul 19, 2019, 08:54 Tom Tromey <tom@tromey.com> wrote:
>>
>> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Christian> 2019-07-11  Christian Biesinger  <cbiesinger@google.com>
>>
>> Christian>      * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
>> Christian>      (lookup_symbol_in_objfile): Change int to block_enum and add a
>> Christian>      gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
>>
>> Thanks, this is ok.  Please check it in.
>
>
> I don't have a committer account -- maybe I should take you up on the offer last time and get one.

I have gotten the account now and pushed this patch.

Christian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]