This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[8.3 backport][gdb/symtab] Fix symbol loading performance regression
- From: Tom de Vries <tdevries at suse dot de>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org, Joel Brobecker <brobecker at adacore dot com>
- Date: Thu, 18 Jul 2019 16:23:52 +0200
- Subject: [8.3 backport][gdb/symtab] Fix symbol loading performance regression
- References: <20190513092700.GA9733@delia> <87ef4hxg4j.fsf@tromey.com>
On 29-05-19 20:36, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> 2019-05-11 Tom de Vries <tdevries@suse.de>
>
> Tom> PR symtab/24545
> Tom> * symtab.c (struct demangled_name_entry): Add language field.
> Tom> (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
> Tom> static minimal symbol". Set and use language field.
>
> Thanks for doing this.
>
> Tom> + char *demangled_name = symbol_find_demangled_name (gsymbol,
> Tom> + linkage_name_copy);
>
> I think it would be better to do
>
> gdb::unique_xmalloc_ptr<char> demangled_name (...);
>
> and then adjust the code to use ".get ()" as needed.
>
> This is ok with that change.
Is this also ok for 8.3.1? The patch applies cleanly.
Thanks,
- Tom