This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][ARM][GDB]: gdb cannot step across CMSE secure entry function code.

From: Simon Marchi <simark at simark dot ca>
To: Alan Hayward <Alan dot Hayward at arm dot com>, Srinath Parvathaneni <Srinath dot Parvathaneni at arm dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
Date: Wed, 17 Jul 2019 17:15:09 -0400
Subject: Re: [PATCH][ARM][GDB]: gdb cannot step across CMSE secure entry function code.
References: <DBBPR08MB4775E54498B86FB214A14C2C9BC90@DBBPR08MB4775.eurprd08.prod.outlook.com> <03A1C8C2-EB12-4951-9D96-1C831D59665E@arm.com>

On 2019-07-17 2:35 p.m., Alan Hayward wrote:
>> +{
>> + if (sec != NULL && sec->the_bfd_section != NULL
>> +     && sec->the_bfd_section->name != NULL
>> +     && !strcmp (sec->the_bfd_section->name,".gnu.sgstubs”))
> 
> "0 == strcmp” is easier to parse than !strcmp.

Nothing much to add after Alan's review, but I just wanted to note that we have streq for this, e.g.:

  if (streq (sec->the_bfd_section->name, ".gnu.sgstubs”))

Simon

References:
- [PATCH][ARM][GDB]: gdb cannot step across CMSE secure entry function code.
  - From: Srinath Parvathaneni
- Re: [PATCH][ARM][GDB]: gdb cannot step across CMSE secure entry function code.
  - From: Alan Hayward

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]