This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING^3][PATCH][readline] Fix heap-buffer-overflow in update_line
- From: Chet Ramey <chet dot ramey at case dot edu>
- To: Tom Tromey <tom at tromey dot com>, Tom de Vries <tdevries at suse dot de>
- Cc: chet dot ramey at case dot edu, gdb-patches at sourceware dot org
- Date: Fri, 12 Jul 2019 09:35:31 -0400
- Subject: Re: [PING^3][PATCH][readline] Fix heap-buffer-overflow in update_line
- References: <20190525112458.GA3838@delia> <face8ced-ebe9-86d7-6453-4de8c3449250@suse.de> <24b69803-ed21-118f-f50b-b5f1b321ddea@suse.de> <40b0c874-9b8e-c6f5-ee3b-401ef0118d9b@suse.de> <87v9w89ucv.fsf@tromey.com>
- Reply-to: chet dot ramey at case dot edu
On 7/11/19 4:41 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Apologies for the delay on this.
>
> Tom> Ping^3.
>
>>>>> 2019-05-25 Tom de Vries <tdevries@suse.de>
>>>>> Chet Ramey <chet.ramey@case.edu>
>>>>>
>>>>> PR cli/24514
>>>>> * readline/display.c (init_line_structures, rl_redisplay): Ensure
>>>>> line_size is at least _rl_screenwidth + 1.
>
> I don't know this part of readline very well. However, if Chet approved
> it and/or put it into upstream readline, then it is fine for gdb.
I did.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/