This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] gdb: Switch "info types" over to use the gdb::options framework


> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Fri, 12 Jul 2019 12:37:04 +0100
> 
> Adds a new -q flag to "info types" using the gdb::option framework.
> This -q flag is similar to the -q flag already present for "info
> variables" and "info functions".

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 4e479bf738b..cc1d58520d4 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -211,6 +211,10 @@ maint show test-options-completion-result
>  
>      (gdb) print -raw -pretty -object off -- *myptr
>  
> +  ** The "info types" command now supports the '-q' flag to disable
> +     printing of some header information in a similar fashion to "info
> +     variables" and "info functions".
> +

This part is OK.

> +@item info types [-q] [@var{regexp}]
>  Print a brief description of all types whose names match the regular
>  expression @var{regexp} (or all types in your program, if you supply
>  no argument).  Each complete typename is matched as though it were a
> @@ -18449,6 +18448,9 @@
>  @code{whatis}, it does not print a detailed description; second, it
>  lists all source files and line numbers where a type is defined.
>  
> +The optional flag @samp{-q}, which stands for @samp{quiet}, disables
> +printing header information.

I don't see "headers" described anywhere in the preceding text, so
"disables printing header information" here is not clear enough.
Besides, the command's doc string says "some headers and messages",
which seems to imply more than just "headers" is suppressed by this
switch.

Can you please make the effect of this switch more clear?

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]