Re: [PATCH 0/2] Make use of gdb::options for info variabels|functions|args|locals

[Pedro Alves <palves at redhat dot com>]

On 7/11/19 4:53 PM, Andrew Burgess wrote:
> * Pedro Alves <palves@redhat.com> [2019-07-11 14:36:23 +0100]:
> 
>> On 7/11/19 2:20 PM, Andrew Burgess wrote:
>>> Additional use of the gdb::options framework.
>>>
>>> --
>>>
>>> Andrew Burgess (2):
>>>   gdb: Allow quoting around string options in the gdb::option framework
>>
>> Ahaha, that didn't take long.  Thanks for doing this.  LGTM.
>>
>>>   gdb: Make use of gdb::option framework for some info commands
>>
>> This LGTM to me too, but, I was surprised to find this doesn't add
>> completers at the same time?
> 
> Something like this, maybe?

_Exactly_ like that.  Perfect.

So far, I've listed this sort of improvement under
"Completion improvements" in NEWS.  I think you lists these commands
there too, and it'd be an obvious change.

> +
> +  const char *word = advance_to_expression_complete_word_point (tracker, text);
> +  symbol_completer (ignore, tracker, text, word);
> +  return;

Redundant "return".

Thanks,
Pedro Alves