This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] "catch catch/throw/rethrow", breakpoint -> catchpoint

From: Tom Tromey <tom at tromey dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
Date: Tue, 09 Jul 2019 08:48:47 -0600
Subject: Re: [PATCH 2/2] "catch catch/throw/rethrow", breakpoint -> catchpoint
References: <20190705160055.13355-1-palves@redhat.com> <20190705160055.13355-3-palves@redhat.com> <20190709095507.GJ23204@embecosm.com>

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> I agree for users knowing the address is probably not helpful, but we
Andrew> also have 'maintenance info breakpoints'.  I think it might (one day)
Andrew> be helpful if we _did_ print the address in the maintenance version of
Andrew> the command.

This makes sense to me as well.

I read the patch and it looked fine to me.

Tom

References:
- [PATCH 0/2] Fix "info break" crash + make "catch catch" show as catchpoint
  - From: Pedro Alves
- [PATCH 2/2] "catch catch/throw/rethrow", breakpoint -> catchpoint
  - From: Pedro Alves
- Re: [PATCH 2/2] "catch catch/throw/rethrow", breakpoint -> catchpoint
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]