This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2 2/2] gdb: Don't skip prologue for explicit line breakpoints in assembler


LGTM.  A couple nits below.

On 7/1/19 7:03 PM, Andrew Burgess wrote:

> +   This file is part of the gdb testsuite.
> +
> +   Test that a breakpoint place by line number in an assembler file

"placed", I believe.

> +   will stop at the specified line.  Previously versions of GDB have
> +   incorrectly invoked the prologue analysis logic and skipped
> +   forward.  */
> +
> +        .text
> +        .global main
> +main:
> +        nop
> +test:
> +        /* The next two instructions are required to look like an
> +	   x86-64 prologue so that GDB's prologue scanner will spot
> +           them and skip forward.  */

spaces vs tabs.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]