This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Restore original GDB prompt in define.exp
- From: Tom Tromey <tom at tromey dot com>
- To: Richard Bunt <Richard dot Bunt at arm dot com>
- Cc: "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Wed, 03 Jul 2019 08:22:37 -0600
- Subject: Re: [PATCH] Restore original GDB prompt in define.exp
- References: <32795df0-3a46-2b7d-3db8-2902e0f55481@arm.com>
>>>>> "Richard" == Richard Bunt <Richard.Bunt@arm.com> writes:
Richard> 2019-06-08 Richard Bunt <richard.bunt@arm.com>
Richard> Stephen Roberts <stephen.roberts@arm.com>
Richard> * gdb.base/define.exp: Restore original prompt.
Thank you for the patch.
This is ok.
Richard> -gdb_test_multiple "set prompt \\(gdb\\) " "reset gdb_prompt" {
Richard> +gdb_test_multiple "set prompt $gdb_prompt " "reset gdb_prompt" {
This is peculiar because both the original code and the new code have
backslashes in the "set" command -- gdb_prompt is actually a regexp, not
just a plain string. But, it works anyhow, I guess something along the
way is ignoring the "\". So, although it is weird, your patch doesn't
make it any worse.
Tom